Skip to content

Actions: clarify doc for untrusted checkout #20204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2025

Conversation

p-
Copy link
Member

@p- p- commented Aug 11, 2025

Add some small samples to show how the untrusted code could potentially be executed in an action workflow. (The change is the same for all 3 doc files)

@p- p- requested a review from a team as a code owner August 11, 2025 09:59
@Copilot Copilot AI review requested due to automatic review settings August 11, 2025 09:59
@github-actions github-actions bot added documentation Actions Analysis of GitHub Actions labels Aug 11, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances documentation for GitHub Actions security by clarifying how untrusted checkout scenarios can lead to code execution vulnerabilities. The changes add concrete examples to help developers understand the security risks.

  • Added specific example of how untrusted code execution can occur (modified build scripts)
  • Enhanced code comments to illustrate the execution of scripts from package.json during npm install

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
UntrustedCheckoutMedium.md Updated overview text and added explanatory comment for npm install vulnerability
UntrustedCheckoutHigh.md Updated overview text and added explanatory comment for npm install vulnerability
UntrustedCheckoutCritical.md Updated overview text and added explanatory comment for npm install vulnerability

@p-
Copy link
Member Author

p- commented Aug 11, 2025

@JarLob tagging you here, since I cannot add you as reviewer.

Copy link
Contributor

@Napalys Napalys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@Napalys Napalys merged commit 6e38087 into github:main Aug 11, 2025
9 checks passed
@p- p- deleted the p--actions-untrusted-checkout-doc branch August 11, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Actions Analysis of GitHub Actions documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants