Skip to content

Conversation

shati-patel
Copy link
Contributor

Follow-up to #3675. (Thanks for creating this new content @owen-mc!)

Here are some minor peripheral changes to keep the AST class reference for Go consistent with our other docs.

Copy link
Contributor

@owen-mc owen-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I only found out that there is a much more succinct way of dealing with links in RST after making the go one, when I started looking at the java one more closely. :(

Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too 💖

As Shati says, it's great to have this new content @owen-mc 😄

@felicitymay felicitymay removed the request for review from jf205 June 11, 2020 11:21
@semmle-qlci semmle-qlci merged commit c2de54f into github:rc/1.24 Jun 11, 2020
@shati-patel shati-patel deleted the ast-go-edits branch June 11, 2020 11:43
@max-schaefer
Copy link
Contributor

@owen-mc, can you make a corresponding PR against https://github.com/github/codeql-go (rc/1.24 branch)?

owen-mc added a commit to owen-mc/codeql-go that referenced this pull request Jun 11, 2020
owen-mc added a commit to owen-mc/codeql-go that referenced this pull request Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants