Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: github/details-menu-element
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 63f84ba
Choose a base ref
...
head repository: github/details-menu-element
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 03d0c3d
Choose a head ref
  • 9 commits
  • 5 files changed
  • 5 contributors

Commits on Jun 3, 2020

  1. Set return type

    @muan
    muan committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    d071704 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2020

  1. Bump lodash from 4.17.15 to 4.17.19 

    Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.15...4.17.19)

Signed-off-by: dependabot[bot] <support@github.com>
    @dependabot
    dependabot[bot] authored Jul 16, 2020
    Configuration menu
    Copy the full SHA
    e2e6387 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #49 from github/dependabot/npm_and_yarn/lodash-4.1… 

    …7.19

Bump lodash from 4.17.15 to 4.17.19
    @koddsson
    koddsson authored Jul 16, 2020
    Configuration menu
    Copy the full SHA
    73048a1 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2021

  1. Ignore summary when focusing to autofocus in the popup 

    If the dropdown itself is the `autofocus` field in the page, then `<details-menu>` fails to set focus to any other `autofocus` element in the popup when displaying it.
Reason being that the selector matches first the `<summary>` and wrongly sets focus to it instead.
    @pablonete
    pablonete authored Jul 20, 2021
    Configuration menu
    Copy the full SHA
    91ca4de View commit details
    Browse the repository at this point in the history

  2. Add example of autofocus

    @pablonete
    pablonete committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    a016867 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2021

  1. Add test for the fixed scenario.

    @pablonete
    pablonete committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    6c5c99e View commit details
    Browse the repository at this point in the history

  2. Drop placeholder. 

    Co-authored-by: Kristján Oddsson <koddsson@github.com>
    @pablonete
    pablonete and Kristján Oddsson authored Jul 21, 2021
    Configuration menu
    Copy the full SHA
    342e80f View commit details
    Browse the repository at this point in the history

  3. Merge pull request #51 from pablonete/autofocus-fix 

    Autofocus fix
    @koddsson
    koddsson authored Jul 21, 2021
    Configuration menu
    Copy the full SHA
    202237d View commit details
    Browse the repository at this point in the history

  4. 1.0.10

    @koddsson
    koddsson committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    03d0c3d View commit details
    Browse the repository at this point in the history
Loading