Skip to content

Install chrome in codespaces via Dockerfile rather than use node-chrmium package #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

KyFaSt
Copy link
Contributor

@KyFaSt KyFaSt commented Apr 11, 2023

I'm working on adding trusted types compatibility to this package and wasn't able to run the tests in a codespace because chrome wouldn't start. I looked at auto-complete-element and changing the installation of chrome seemed to fix the problem in this project too.

@KyFaSt KyFaSt requested a review from a team as a code owner April 11, 2023 23:32
@primer-css
Copy link

👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.

  • 🎨 If this is a PR that includes a visual change, please make sure to add screenshots in the description or deploy this code to a lab machine with instructions for how to test.
  • If this is a PR that includes changes to an interaction, please include a video recording in the description.
  • ⚠️ If this is urgent, please visit us in #primer on Slack and tag the first responders listed in the channel topic.

@KyFaSt KyFaSt requested a review from a team April 12, 2023 13:34
Copy link

@rezrah rezrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 👍

@KyFaSt KyFaSt merged commit 8bd6a58 into main Apr 20, 2023
@KyFaSt KyFaSt deleted the kyfast-codespace-docker-chrome branch April 20, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants