Skip to content

Stop stacking list styles #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Stop stacking list styles #52

wants to merge 3 commits into from

Conversation

paxos
Copy link
Contributor

@paxos paxos commented Nov 22, 2021

Stops the stacking of lists when using different list styles.

Before:

before.mov

After:

after.mov

Fixes https://github.com/github/special-projects/issues/598

@paxos paxos marked this pull request as ready for review November 22, 2021 22:15
@paxos paxos requested a review from a team as a code owner November 22, 2021 22:15
@paxos paxos requested review from keithamus and srt32 November 22, 2021 22:15
keithamus
keithamus reviewed Nov 23, 2021
View reviewed changes
Copy link
Contributor

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good change 👍

Can we please add tests for this, to validate the behaviour and avoid regressions.

@paxos
Copy link
Contributor Author

paxos commented Nov 24, 2021

Thank you @keithamus - added more tests.

I am putting this PR back to draft for now. I am planning to propose some more changes next week.

@paxos paxos marked this pull request as draft November 24, 2021 22:40
@paxos paxos mentioned this pull request Dec 2, 2021
Merged
@paxos
Copy link
Contributor Author

paxos commented Dec 2, 2021

Changes are included in #53

@paxos paxos closed this Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithamus keithamus keithamus left review comments

@srt32 srt32 Awaiting requested review from srt32 srt32 was automatically assigned from github/ui-frameworks-reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paxos @keithamus