Add event detail - eventType to 'remote-input-success' customEvent #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was having trouble running testing locally due to dependencies being so old. I will keep trying locally but I was hoping the tests ran in the PR 😭 |
keithamus
reviewed
Mar 28, 2024
src/index.ts
Outdated
| const fetch = fetchResults.bind(null, this, true) | ||
| const state = {currentQuery: null, oninput: debounce(fetch), fetch, controller: null} | ||
| const fetch = (e: Event) => fetchResults.bind(null, this, true, e) | ||
| const state = {currentQuery: null, oninput: (e: Event) => debounce(fetch(e)), fetch, controller: null} |
There was a problem hiding this comment.
I think this would be better:
Suggested change
| const state = {currentQuery: null, oninput: (e: Event) => debounce(fetch(e)), fetch, controller: null} | |
| const state = {currentQuery: null, oninput: debounce((e: Event) => fetch(e)), fetch, controller: null} |
keithamus
approved these changes
Mar 28, 2024
…com/github/remote-input-element into kendallg/add-event-detail-eventType
kendallgassner
commented
Mar 29, 2024
|
The PR to update linting and add it to the workflow that runs on pull requests: |
kendallgassner
commented
Mar 29, 2024
kendallgassner
commented
Mar 29, 2024
|
I am not authorized to merge this pull-request. Not sure if only Primer can... but this is good to go! |
jonrohan
approved these changes
Apr 8, 2024
| - name: Run build | ||
| run: npm run build | ||
| - name: Run test | ||
| run: npm run test |
There was a problem hiding this comment.
can't believe we weren't doing this already 🤦🏻
| @@ -23,14 +22,12 @@ | |||
| "devDependencies": { | |||
| "chai": "^4.1.2", | |||
| "chromium": "^3.0.3", | |||
| "eslint": "^6.8.0", | |||
| "eslint-plugin-github": "^3.4.1", | |||
There was a problem hiding this comment.
ah never mind, found the update pr 👍🏻
There was a problem hiding this comment.
Also, I am not authorized to merge so feel free to merge whenever.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
We need to announce the number of results when a remote-input has finished fetching results. This announcement should only happen on input
changeand therefore I need to know what triggered the 'remote-input-success' customEvent.Pairing with @TylerJDev to fix broken karma setup, ensure successful tests runs, and create a workflow to run the tests on PRs. He graciously offered to work on this pr as I became swamped on Thursday!