generated from github/custom-element-boilerplate
-
Notifications
You must be signed in to change notification settings - Fork 17
Add event detail - eventType to 'remote-input-success' customEvent #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
5fb21bb
Add event detail - eventType to success customEvent
kendallgassner 7886c72
clean;
kendallgassner a0aab0e
fix debounce
kendallgassner 92337bc
Add instanceof to error
TylerJDev 4a212b1
Update test
TylerJDev a2157a3
Merge branch 'kendallg/add-event-detail-eventType' of https://github.…
TylerJDev 07422fd
formatting
TylerJDev af8252a
add back eslint
TylerJDev 5c96242
remove lint for now -- will add updated lint versions in a new PR
TylerJDev e120777
Apply suggestion from @kendallgassner
kendallgassner 7fdbaad
Apply suggestions from code review
kendallgassner b5e7c4f
formatting
TylerJDev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| name: Build and run tests | ||
|
|
||
| 'on': | ||
| push: | ||
| branches: | ||
| - main | ||
| pull_request: | ||
| types: | ||
| - opened | ||
| - synchronize | ||
|
|
||
| jobs: | ||
| test: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Install dependencies | ||
| run: npm ci | ||
| - name: Run build | ||
| run: npm run build | ||
| - name: Run test | ||
| run: npm run test | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't believe we weren't doing this already 🤦🏻