Pull requests missing #971
Comments
|
+1 Would be great if there are any insights on how to fix this |
|
I have a similar issue in https://github.com/YarikTH/ureact when tried to use this generator. And it seems that I found the root of at least my problem. It's because I started to merge PR using rebase. It seems that the changelog-generator doesn't know how to handle this, so it ignores PRs and emits a warning. Note: I tried to use changelog-generator for the first time, so I have nothing to compare. |
|
Have this been by any chance confirmed by the authors? @skywinder @olleolleolle |
|
+1 Only seems to happen for our most recent PR:s. The PR merged before the error appears has a lot of force pushes (locustio/locust#1805), but other than that I dont know what could be causing this. |
|
Huh. It started working for me again. Maybe after I tagged master? |
|
@cyberw Tagged master? If you would be able to identify what makes it work / not work we would be super keen to try it on our end right away :) |
|
That's really the only thing I changed. I first pushed a commit directly to master (locustio/locust@61b3c28) but that didnt seem to do anything. But once I tagged that commit with 2.0.0b2 (created a release in GH web UI) it started working. |
|
Oh, you mean that the release tag should be included in the |
|
I dont think my issue relates to the tagging itself (I dont think I've had to tag before creating the changelog before? I'm using the --future-release param), I think it just made something refresh or work differently when there was a new tag. |
|
Before tagging: After tagging: |
|
Maybe the core issue is "not found in the release branch"? Those merge commits should definitely be in the release branch (master), but maybe the tag helped changelog generator find it in some other way? |
|
The more I think about it, the more that makes sense: It seems PR:s merged after the last tag arent found. |
|
Yup, and now I merged another PR (without adding a tag), and the error is visible again (for that new PR). |
|
Can you reproduce it? I'm kind of in a catch 22 situation in using tagging as a workaround, because I need to update the changelog before tagging (because tagging is what starts my package upload/release process), and I right now I cant do that :) |
|
Hi, |
This changelog was generated by hand because of github-changelog-generator/github-changelog-generator#971
This changelog was generated by hand because of github-changelog-generator/github-changelog-generator#971
|
I've another repository with the same issue: puppetlabs/puppet-lint#13 |
|
I can also reproduce the issue from voxpupuli/beaker#1711 with the latest docker container: The listed PRs were merged into master / the release branch: The following indeed not: |
|
I'm seeing this in https://github.com/boutproject/BOUT-dev, except that I'm running like: Running like: fetches the closed issues, but removes all of the merged PRs from the changelog. |
|
Do we have any update on this maybe? A chance that it could be fixed in the upstream or some sort of FAQ added with an official workaround? |
|
For those of you seeing this issue, is it happening when your release branch is not the repository's default branch? If so, then #979 should fix it for you once merged / released |
Unfortunately this is happening on master branch for me. |
|
+1 Same here...we are encountering the error even though we are releasing on the default branch |
|
@cyberw I'm currently experimenting with using release-drafter instead |
|
Facing the same issue on the master branch for https://github.com/fission/fission All PRs apart from master from the last tagged release not reflecting in the changelog. https://github.com/fission/fission/blob/master/hack/changelog.sh |
|
Still no word from @olleolleolle or any other maintainers? |
|
hey. I did some poking on the codebase. I can still reproduce this issue but I'm unable to track it down :( Has anyone some ideas here? |
|
As a workaround, I created a temporary new tag (e.g. Then I ran the command it worked. I then deleted the tag locally and in github, to clean things up again. |
|
Hi people. This still happens with the latest master branch of github-changelog-generator. I cannot push a temporary tag to GitHub because that would automatically release it. Has someone else an idea what's happening here? |
|
Pinging @bruce-szalwinski because I just saw you commit something to master :) I dont know, but it seems to me that this would be a showstopper for everyone not tagging before generating the changelog, yet this project doesnt seem completely stalled? |
|
Experiencing this exact same thing, pushing temporary tags doesn't even do the job for me. |
|
I'm having this issue right now, does a fix has been found for this ? |
|
For us the issue is resolved with the latest master branch. We just needed to figure out how to build an docker image. Any chance of an official release soonish? |
|
Hey @skywinder Sorry for nagging about this, but is there any small chance you could have a look at this? I'd look into it myself but I'm busy with my own project and it would take a long time for me to get started. Thanks. |
|
for my projects it's still broken, even with the latest master branch of github-changelog-generator. We generate the changelog on our master branch, not a specific release branch. This works fine on mose repos I have, except a few (like the mentioned beaker one) |
|
Spam ping @bruce-szalwinski @olleolleolle @skywinder :) |
|
I'm still dreaming of a fix @olleolleolle @skywinder :) |
|
My impression is, that the changelog_generator somehow jumps between the branches. Is that possible?? I attached a screenshot from GitKraken on repo nextcloud/forms. In the middle, there are the two commits called "Fix upgrading", of which one was done towards master and then ported to the This just as a guess from investigating. Not sure, if that mechanism could happen with how ghcg works. 🤷♂️
|
|
I added and then immediately removed a tag on my master branch and it worked. The tag was not even after the last merge, but still managed to trigger the inclusion of all all PRs. Kind of a bad workaround, but still a workaround. |
|
Folks @bruce-szalwinski @olleolleolle @skywinder this bug has finally got to the point were working around it is more work than making a change log by had, and we are looking at alternates |
This changelog was crafted by hand, due to github-changelog-generator/github-changelog-generator#971 I used voxpupuli/beaker@4.39.0...master to figure out the merged pull requests. A few of them only touched the CI config or the tests, so I didn't include them.
|
I did some more tests today in https://github.com/voxpupuli/beaker and we still see the above mentioned errors with the master branch of github-changelog-generator :( |
|
any help for this issue, @bastelfreak Check the Rails upgrade guide at https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#new-activesupport-cache-serialization-format |
|
I'm not the maintainer here, just a user. And I wasn't able to fix it for the beaker repo I linked above :( |
Describe the bug
We recently noticed that in latest releases of our Seldon Core the
Merged pull requestssection is missing.To Reproduce
Full changelog with missing pull requests for releases 1.8 and 1.9 is here.
Steps to reproduce the behavior:
Expected behavior
No errors and pull requests always included.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: