Get commits from release branch #979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks nice, did this change the test output? Or was that red before this change? |
|
The failure on CI does look related to my change; will have a look today |
|
Ok tests are green |
olleolleolle
approved these changes
Aug 18, 2021
There was a problem hiding this comment.
Right, this API usage update takes "configured release branch" into account.
Thanks for the update @pokey!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue should help with #971, #891 and #927, but looks like it might not completely address all cases seen by users
The issue is that the commits API endpoint on Github grabs the commits for the repository's default branch by default. Thus, if the release branch is not the repository's default branch, we won't find any commits for the release branch