Fix missing release branch when looking for commits #1055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Right, 30 branches lying around is nothing. Even 100 could be very little. But offering the default options to the API request should be uncontroversial. |
|
The query also brings back deleted branches which doesn’t help. I’ll look shortly to see if there’s a parameter to control that. |
|
The latest commit iterates the pages so no 100 limit either. |
|
Hey @olleolleolle, any chance of getting this merged? I’m also happy to address any suggestions if you have any. |
olleolleolle
approved these changes
Nov 11, 2024
Co-authored-by: Olle Jonsson <olle.jonsson@gmail.com>
|
Thanks, I've applied the suggestions and retested the code and all works ok. |
|
Hey @olleolleolle, are you ok to merge this now? |
|
Hey @olleolleolle, sorry to pester but could we get this merged? |
15516a6
into
github-changelog-generator:master
3 checks passed
|
Thanks for merging @olleolleolle. Do you plan to do a release anytime soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default responses per page of 30 can cause the release branch to be missed out of the query results during the check for commits in the release branch.
This causes WARNING:
merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found. #971This PR sets the default query response size to 100 to reduce the likelihood of this happening. A more permanent solution could be to restrict the branches query to the required branch.