Do not alter pull_requests while iterating on it #271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deleting elements of an array while iterating on it
results in never seeing the last element.
> a = [1,2,3]
=> [1, 2, 3]
> a.each do |e|
> p a
> a.delete(e)
> end
[1, 2, 3]
[2, 3]
=> [2]
|
@skywinder all builds are currently failing on the master branch, I'm willing to rebase once they pass. |
|
@raphink Great attention to details. Thank you again! Can't understand, why build start failing. |
skywinder
added a commit
that referenced
this pull request
Aug 27, 2015
Do not alter pull_requests while iterating on it
|
btw: @raphink You help me a lot with cool enhancements and your code always is very clean. Thanks again. 👍 |
|
Just one more project to watch for, that can't hurt ;-) |
|
Fancy a patch release @skywinder ? |
|
I thought that can fix some other things before release, but don't have a time. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleting elements of an array while iterating on it
results in never seeing the last element.