Fix section mapping, hiding untagged PRs, and hiding untagged issues #550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before we do anything, let's get a solid expectation of what we want our section headers to look like. Signed-off-by: Tom Duffield <tom@chef.io>
This change neccesitated changing the behavior or the `filter_since_tag`. Since we want our compare links to include the since tag, we need to keep that tag in the filtered list. Instead, we detect that the tag is the since tag and filter it out. This will prevent the since_tag header from being duplicated when pulling from a base. The same goes for the first tag listed in between_tags. We don't want an empty section header for this. Signed-off-by: Tom Duffield <tom@chef.io>
Signed-off-by: Tom Duffield <tom@chef.io>
Because we need might need excluded tags to build compare links, the section map generator needs to have access to those tags. But, we don't want excluded tags to have section headers. So instead, we'll create another copy of the list that doesn't have tags excluded. Signed-off-by: Tom Duffield <tom@chef.io>
Signed-off-by: Tom Duffield <tom@chef.io>
Rather than having the last tag be an empty husk, generate a full changelog link using the first sha from the repository. Signed-off-by: Tom Duffield <tom@chef.io>
As far as I can tell, `add_pr_wo_labels` wasn't actually implemented. Implementing this per the documentation. Signed-off-by: Tom Duffield <tom@chef.io>
When `add_issues_wo_labels` is false, do not include issues that do not have any labels in the CHANGELOG (per documentation). Signed-off-by: Tom Duffield <tom@chef.io>
Signed-off-by: Tom Duffield <tom@chef.io>
Signed-off-by: Tom Duffield <tom@chef.io>
Signed-off-by: Tom Duffield <tom@chef.io>
Signed-off-by: Thom May <thom@chef.io>
This is a rebase and resubmission of github-changelog-generator#453
|
I am grateful for this reasoned careful change. |
DavidS
added a commit
to DavidS/pdk
that referenced
this pull request
Aug 1, 2017
Since github-changelog-generator/github-changelog-generator#550 was merged, we can switch to the upstream repo. Once a new version is released we can drop the git reference altogether. This also includes a minor config change to make the rake task work, and the current output to show the minimal changes to the CHANGELOG file's format, and no content changes in the historical entries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase and resubmission of #453 to pass rubocop/tests and remove
--between-tagsreferences because it was removed in #501