Implemented a Dockerfile #592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dockerfile
Outdated
| @@ -0,0 +1,14 @@ | |||
| FROM ruby:2.4-alpine3.6 | |||
|
|
|||
| LABEL maintainer "olle.jonsson@gmail.com" | |||
There was a problem hiding this comment.
Can you be the maintainer of this Dockerfile? Care to join?
|
Auto-bumping the build version in a script seems like an OK release process. I use the I'm thinking we can wrap this inside a Rake task as a step later. So, make it an explicit version number. |
|
@olleolleolle done, added the explicit version |
olleolleolle
approved these changes
Nov 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request I implemented a Dockerfile and added a couple of notes to the README (to refine, asking for help on this).
Relevant issue: #591
Implementation
Base Image
I chose
ruby:2.4-alpine3.6as a base for this Docker image after checking CHANGELOG.md (see #487).Such base always points to the latest 2.4.x release. We can explicitely point to
ruby:2.4.1-alpine3.6if desired (but then we are creating another bit to update on each Ruby version bump).I picked up the latest Alpine variant to reduce the size of the resulting image.
GitHub Changelog Generator Installation
The installation is carried out by the following command:
RUN gem install github_changelog_generatorThis means that
gemwill install the current default version. We can extend this to allow the installation of pre-release versions and even by explicitly specify the version to install (this means that the Dockerfile has to be (maybe automatically) modified on each version bump). Let talk about this.I can also configure Travis CI to build the Docker image on each commit, to test if everything is fine on this side. Let's decide first how to handle the version to install.
Volumes
We declare
/usr/local/src/your-app(feel free to find a better name for the directory) as a Docker Volume and then we expect that the user bind mounts his repository root to/usr/local/src/your-app, as we suggest in the README.README
As stated, I'm asking for help here. Can you please check if the only addition is enough?