-
-
Notifications
You must be signed in to change notification settings - Fork 849
Dockerfile and Docker automated builds #591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I’d be happy to have a PR!
… On 23 Nov 2017, at 11:28, Marco Ferrari ***@***.***> wrote:
Hi @olleolleolle
Would you mind accepting a pull request for a Dockerfile? I can also configure a Docker Hub automated build that runs on each tag (even on each commit if that is the desired behaviour).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Ok, I'm working on it. How do you publish new releases on Rubygems? I need this info to think about the Dockerfile and the configuration of automated builds |
@olleolleolle here it is: #592 |
@ferrarimarco I use the |
As soon as (and if) #592 is merged I'll configure the Docker Hub automated build if it's fine for you |
* Implemented a Dockerfile. See #591 * Set Ferrari Marco as a maintainer * Explicitly install the latest released version
Ok I can now configure the Docker automated build. Which prefix should we use for the image? Maybe skywinder to be consistent with this repository |
@olleolleolle I don't have access to this repo configuration, so I cannot enable the automatic build all by myself. Let's explore the options: Automated build with Docker hubIf we want to use (like previously suggested) Docker Hub for builds we should (since skywinder is a user account on GitHub and not GitHub Organization):
Automated build with Travis CIEach time a tag is pushed, we use Travis CI to build the Docker image and push it under the skywinder Docker Hub organization. For this we need update the This approach has the added benefit that we can use Travis CI environment variables (in our case we are going to use the git tag) to tag the docker image and to pass it as a build time variable instead of hardcoding the version in the Dockerfile. Note 1: we should run the "build docker image & push to docker-hub" step as the very last, after the gem has been uploaded on Rubygems. So this approach is not suitable if you want to deploy on Rubygems in another context (i.e. not from Travis CI). Note 2: as said, we should run the "build docker image & push to docker-hub" step only on when a new tag is published on GitHub because the Dockerfile I provided downloads GitHub Changelog Generator from Rubygems and does not compile it from source. It's possible to implement a Dockerfile for this use case (that will work on each commit, pull request and tag), but this is another story (I can help you in this also if needed). |
Skywinder is the GitHub username of a person. (Hi, @skywinder!) Perhaps the time has arrived when we must use an org? |
I know he's a person :) I created a skywinder organization on Docker Hub so everyone in that org could manage its Docker images. Otherwise we would have to share the credentials. And yes, by creating a GitHub organization we could solve this issue. EDIT: any updates? @olleolleolle @skywinder |
Hello everyone! |
the same name seems resonable to me 👍 |
still no automated build for github-changelog-generator ?
|
Hey there! Any luck with this work? There is an image, https://hub.docker.com/r/skywinder exists. Just a matter of adding this repository, no? For folks who do not like pulling random peoples repository, a poor man suggestion that keeps your system clean:
|
@ojongerius Would you care to put those words into a PR to the README? |
@ojongerius https://hub.docker.com/r/skywinder was created before #595 |
@olleolleolle @skywinder if we want to move ahead before #595, we have some alternatives (but let's wait for the deletion of skywinder organization I asked today):
|
@ferrarimarco Do you want to shepherd the Docker parts? Welcome! Awesome. 2 is a good option, then! |
@ferrarimarco could you please update the README to use that url instead of the current broken link? Also, thank you for Dockerising this! |
there is a PR for that #634 |
Hi @olleolleolle
Would you mind accepting a pull request for a Dockerfile? I can also configure a Docker Hub automated build that runs on each tag (even on each commit if that is the desired behaviour).
The text was updated successfully, but these errors were encountered: