Skip to content

Remove docker bits #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2018
Merged

Remove docker bits #634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b73cf7
Remove Dockerfile
ferrarimarco Mar 28, 2018
80d82e4
README: use ferrarimarco/changelog-generator docker image
ferrarimarco Mar 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions Dockerfile
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ See also Troubleshooting.

## Running with Docker

$ docker run -it --rm -v "$(pwd)":/usr/local/src/your-app skywinder/github-changelog-generator
$ docker run -it --rm -v "$(pwd)":/usr/local/src/your-app ferrarimarco/github-changelog-generator
Copy link
Member

@skywinder skywinder Apr 15, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay! now we can set it to github-changelog-generator/github-changelog-generator 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot have dashes in docker hub namespaces (yet) (docker/hub-feedback#373). So we have to go with githubchangeloggenerator, or something else


## Output example

Expand Down Expand Up @@ -84,11 +84,11 @@ See also Troubleshooting.
- Run this:

$ github_changelog_generator -u github_username -p github_project

or, on the 1.14.x (current stable release)

$ github_changelog_generator github_username/github_project


- For Github Enterprise repos, specify *both* `--github-site` and `--github-api` options:

Expand Down