Remove docker bits #634
Merged
Remove docker bits #634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olleolleolle
approved these changes
Mar 28, 2018
skywinder
reviewed
Apr 15, 2018
| @@ -49,7 +49,7 @@ See also Troubleshooting. | |||
|
|
|||
| ## Running with Docker | |||
|
|
|||
| $ docker run -it --rm -v "$(pwd)":/usr/local/src/your-app skywinder/github-changelog-generator | |||
| $ docker run -it --rm -v "$(pwd)":/usr/local/src/your-app ferrarimarco/github-changelog-generator | |||
There was a problem hiding this comment.
yay! now we can set it to github-changelog-generator/github-changelog-generator 😉
There was a problem hiding this comment.
We cannot have dashes in docker hub namespaces (yet) (docker/hub-feedback#373). So we have to go with githubchangeloggenerator, or something else
|
@ferrarimarco thank you very much for the support. I was crazy busy with my other projects. I made an organization for that project. And already send you to invite to attend our new org! 🎉 |
|
Cool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This is the output of the discussion on #591
While we wait for a GitHub organization, I am taking care of building a suitable Docker image.
What I did
It's up to you if you want to close #591 after (and if) this PR is merged because it could serve as a reminder of the work that possibly needs to be done (create a Docker Hub org, move the image to that org).