-
-
Notifications
You must be signed in to change notification settings - Fork 849
Allow generator to continue even if any errors encountered in fetch comparison #736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow generator to continue even if any errors encountered in fetch comparison #736
Conversation
Hi @carabasdaniel ! Thanks for this PR. Can you please also provide test cases? |
Hi @ferrarimarco, I've added two unit tests and amended the commit. |
Any update |
I met similar error
|
@ferrarimarco any update on this PR? |
Hi. I'm thinking about the best strategy here. While this PR let you have a changelog, it may be an issue it silently fails during a CI build where you automatically generate the changelog. |
Thanks, @carabasdanie. In order to not change standard behavior we can implement this behavior with a special flag, like |
Added an option for continue_with_errors and rebased to latest master. Extracted add tag to pull request for rubocop complexity in generator fetcher. |
(This code will have some movement under it, as we're waiting on #784 to land, which makes changes in the same places.) |
@carabasdaniel can you rebase against the latest master? |
Hi @ferrarimarco, Rebased but had to remove the initially added unit tests as they were no longer valid. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a comment about code that made me curious.
Have the same problem as @hzxuzhonghu would love to see this PR merged! |
Same problem here...any updates about this PR? |
👍 |
This will be so helpful. Since the tool breaks because of a parent-less commit. |
We've also hit this issue. Any updates about when this can be merged? Thanks :) |
The blocker is an unmet note above:
And, I can not find any test code which does things with this new setting. |
This PR fixes issue: #665
There might be a more elegant solution to catch only StandardError instead of the general Exception but I think this should ensure that the change log is generated in most cases even through various errors encountered by the fetcher.