Skip to content

Handling case insensitive exclude labels #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Handling case insensitive exclude labels #737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
464aadf
CI: Use the shorter image names for less maint (#716)
olleolleolle Oct 1, 2019
00560f7
Fix Performance/Count in entry_spec
ferrarimarco Oct 5, 2019
08459b8
Update changelog before 1.15.0
ferrarimarco Oct 5, 2019
31c9482
v1.15.0
ferrarimarco Oct 5, 2019
2116ff9
Add release instructions to CONTRIBUTING
ferrarimarco Oct 5, 2019
4883a8b
Update the gem release procedure
ferrarimarco Oct 28, 2019
0942d0c
Merge branch 'master' of https://github.com/github-changelog-generato…
rafaeelaudibert Apr 14, 2020
58b262d
Handling case insensitive exclude labels
rafaeelaudibert Oct 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@
- Can we exclude closed Requests [\#632](https://github.com/github-changelog-generator/github-changelog-generator/issues/632)
- Version in master branch hangs on MacOS [\#629](https://github.com/github-changelog-generator/github-changelog-generator/issues/629)
- Some PRs logged for the wrong releases [\#617](https://github.com/github-changelog-generator/github-changelog-generator/issues/617)
- Is there way to list referenced but not closed issues? [\#609](https://github.com/github-changelog-generator/github-changelog-generator/issues/609)
- since\_tag with unreleased tag unexpected behavior [\#604](https://github.com/github-changelog-generator/github-changelog-generator/issues/604)
- Generator doesn't work when I run the command presented in the docs [\#599](https://github.com/github-changelog-generator/github-changelog-generator/issues/599)
- Move repo to organisation [\#595](https://github.com/github-changelog-generator/github-changelog-generator/issues/595)
Expand Down
5 changes: 3 additions & 2 deletions lib/github_changelog_generator/generator/generator_processor.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,10 @@ class Generator
def exclude_issues_by_labels(issues)
return issues if !options[:exclude_labels] || options[:exclude_labels].empty?

exclude_labels = options[:exclude_labels].map(&:downcase)
issues.reject do |issue|
labels = issue["labels"].map { |l| l["name"] }
(labels & options[:exclude_labels]).any?
issue_labels = issue["labels"].map { |label| label["name"].downcase }
(issue_labels & exclude_labels).any?
end
end

Expand Down