Hi @rafaeelaudibert ! Thanks for your PR.

Can you please add some test cases?

thanks!

Sure, will try to add it tonight (or in the next 24 hours).

Hi @rafaeelaudibert ! Thanks for your PR.

Can you please add some test cases?

thanks!

Added a comprehensive test, and updated the old ones to match this change!
I've also upgraded some test performance, as Rubocop was complaining at them.

Looks good. Thanks, @rafaeelaudibert
I think we can merge it! cc @ferrarimarco , please check if you have a time! 🙏

@rafaeelaudibert can you please squash the commits in a single one now that's almost ready?

It's going to be easier to review.

Thanks!

Hey guys! Thanks for the awesome comments. Squashed it, and ready for review/merge.

@rafaeelaudibert Thanks for the improvement - there's been some code movement under the feet of this (nice!) PR.

Would you be able to rebase on master?

Looks like I fucked up while rebasing and lost the commit with the changes (should have read about rebase better, my bad).

I will try to redo it sometime during the week, sorry for the mistake.

Perhaps there's a git reflog way of getting the changes back? Web search for reflog, might help! Holding my thumbs.

Don't worry, it's the first commit on this branch. Look in the "Files changed" tab in the PR to see what's really changing.

See https://github.com/github-changelog-generator/github-changelog-generator/pull/737/files

The important bit here, is that we squash and merge, not rebase and merge