Fixing 'stack level too deep error' in commits_in_tag #936
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue outlined here.
The
commits_in_tag
method was using a recursive solution to iterate over the entire graph of commits. This caused astack level too deep
error when a sufficiently large number of commits exist in the repository. This solution will produce the same results without the need for recursion/stack usage.I also observed that the
commits_in_tag
method was being called multiple times for the same SHA and was very inefficient. I made a couple of optimizations which make use of a cache of already processed SHAs.Baseline
Adding
@commits_in_tag_cache
Reversing
tags
infetch_tag_shas
and using@commits_in_tag_cache