Fix markers position on fullscreen mode #452
Conversation
src/google_map.js
Outdated
| const mapDom = ReactDOM.findDOMNode(this.googleMapDom_); | ||
| this.geoService_.setViewSize(mapDom.clientWidth, mapDom.clientHeight); | ||
| if (document.fullscreen || document.webkitIsFullScreen || document.mozFullScreen) { | ||
| _this.geoService_.setViewSize(window.innerWidth, window.innerHeight); |
There was a problem hiding this comment.
Fixed, sorry about that!
|
Great find @jbcochery! I was just about to start looking for a fix for #296 when I saw your PR. Crazy timing, for an issue 10 month old. Thanks @istarkov for a great lib! |
|
Wow @emilpalsson same here! I was looking at that issue right now. This is looking great @jbcochery, thank you! And thank you @istarkov for the lib! Looking forward to get this merged. |
|
Any status of when this is getting merged? |
|
I also got bitten by that issue. While the fix offered seems to work (thanks for that!), the real problem is that the ref that GooleMapReact keeps does not point to the div used to render the fullscreen map. The fix works because incidentally, the div to which we should have a ref to has the same size than the window. |
|
@istarkov Hey, how about merging this fix? |
|
@istarkov really need this stuff, merge, please! 😢 😢 😢 |
|
@istarkov Please communicate if this is getting merged or not. It would be a shame if people started working on their own forks and this project would stagnate. |
|
@istarkov We also need this fix. Do you plan on merging this? |
|
Guys I need collaborator-leader of this project, see the readme top. I have no desire now to do anything :-( |
|
@istarkov I understand your position and hope you'll find someone willing to help. I'm sure you'll do. |
|
This is merged and published. Feel free to upgrade to CC @nicolasdelfino @emilpalsson @minhkl @huwr @paupalou @jkettmann @ShepelievD @Venumteam @qur2 @jbcochery |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
On fullscreen mode, the view size should not be computed from the DOM element size, but from the
windowdimensions.Fixes #296