Skip to content

Add fullscreen check for Internet explorer 11 #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 4, 2018
Merged

Add fullscreen check for Internet explorer 11 #485

merged 3 commits into from
Jan 4, 2018

Conversation

omladek
Copy link
Contributor

@omladek omladek commented Dec 22, 2017

Fixing marker position in Internet Explorer 11 in fullscreen mode.
Fixing: #484

Add fullscreen check for Internet explorer 11
80c910d 
Fixing marker position in Internet Explorer 11 in fullscreen mode.
Fixing: google-map-react#484
itsmichaeldiego
itsmichaeldiego reviewed Dec 27, 2017
View reviewed changes
Copy link
Member

@itsmichaeldiego itsmichaeldiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This if is getting really big, could we create a function called isFullScreen and move all this logic there to make it cleaner? Thanks.

@omladek
Copy link
Contributor Author

omladek commented Jan 3, 2018

Code is moved to function isFullScreen.

@emilpalsson
Copy link
Contributor

Great job guys, would love to see this merged as well to complete #452. Thanks!

nicolasdelfino
nicolasdelfino approved these changes Jan 4, 2018
View reviewed changes
Copy link

@nicolasdelfino nicolasdelfino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, go for it

@itsmichaeldiego itsmichaeldiego merged commit e47d955 into google-map-react:master Jan 4, 2018
@itsmichaeldiego
Copy link
Member

@omladek Good job, thanks!

@omladek omladek mentioned this pull request Jan 4, 2018
Closed
@omladek omladek deleted the patch-1 branch January 4, 2018 14:25
@lock
Copy link

lock bot commented Dec 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@itsmichaeldiego itsmichaeldiego itsmichaeldiego approved these changes

@nicolasdelfino nicolasdelfino nicolasdelfino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@omladek @emilpalsson @itsmichaeldiego @nicolasdelfino