-
Notifications
You must be signed in to change notification settings - Fork 855
Update readme #686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update readme #686
Conversation
Update readme to show how to add Google Map API Libraries.
I think this PR should wait for #673 to be fixed first, since adding any library along with the heatmap layer currently causes the other libraries not to be loaded. |
@maruf89 Ideally we want to pass them on the libraries object instead of one by one like that. CC @barakplasma |
@barakplasma Thoughts on my last comment? |
I don't have a strong opinion on which API is better, whether to have a list of boolean props for each library or one 'libraries' object with the same props. I am only mildly inclined to 'namespace' the props under the libraries object, since it does seem a bit more neatly organized than the alternative. |
@barakplasma That's a good idea! Would you like to work on that? Or @maruf89 ? |
@maruf89 would you like to work on this? |
No, I'm not doing anything with computers or coding anymore for a long long
while
wt., 16.04.2019, 12:23 użytkownik Michael Salaverry <
notifications@github.com> napisał:
… @maruf89 <https://github.com/maruf89> would you like to work on this?
I won't be able to work on this any time soon.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#686 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AArd0h2pLhVth_zt7gpqcp_me5a0Rr9Fks5vhZasgaJpZM4YzJc_>
.
|
@barakplasma Let me know if you still interested on this otherwise I will create an issue and ask for help |
Just to clarify, we are talking about fixing #673, or are we talking about updating the readme? I think we should recommend one "right" way to add libraries. |
@barakplasma I am talking about recommending one "right" way to add libraries, which I think will be under |
I agree with putting libraries to load in the library object.
…On Thu, May 16, 2019, 16:34 Michael Diego ***@***.***> wrote:
@barakplasma <https://github.com/barakplasma> I am talking about
recommending one "right" way to add libraries, which I think will be under libraries:
['bar', 'foo']. And keeping this way to pass libraries instead of two.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#686?email_source=notifications&email_token=AAAPLWMYSCIJP5LBBXIRY2LPVVPFLA5CNFSM4GGMS472YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVR2JXQ#issuecomment-493069534>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAPLWJAF77OQKYDICYJ2NLPVVPFLANCNFSM4GGMS47Q>
.
|
@barakplasma If so I think we should remove the other way, so there is only one way and no collision |
Seems that this was taken care by #921 |
@barakplasma @maruf89 Let me know if that works for you folks |
Update readme to show how to add Google Map API Libraries.