Skip to content

Update readme #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update readme #686

wants to merge 1 commit into from

Conversation

maruf89
Copy link

@maruf89 maruf89 commented Nov 26, 2018

Update readme to show how to add Google Map API Libraries.

Update readme to show how to add Google Map API Libraries.
@barakplasma
Copy link
Contributor

I think this PR should wait for #673 to be fixed first, since adding any library along with the heatmap layer currently causes the other libraries not to be loaded.

@itsmichaeldiego
Copy link
Member

@maruf89 Ideally we want to pass them on the libraries object instead of one by one like that. CC @barakplasma

@itsmichaeldiego
Copy link
Member

@barakplasma Thoughts on my last comment?

@barakplasma
Copy link
Contributor

@barakplasma Thoughts on my last comment?

I don't have a strong opinion on which API is better, whether to have a list of boolean props for each library or one 'libraries' object with the same props. I am only mildly inclined to 'namespace' the props under the libraries object, since it does seem a bit more neatly organized than the alternative.

@itsmichaeldiego
Copy link
Member

@barakplasma That's a good idea! Would you like to work on that? Or @maruf89 ?

@barakplasma
Copy link
Contributor

@maruf89 would you like to work on this?
I won't be able to work on this any time soon.

@maruf89
Copy link
Author

maruf89 commented Apr 16, 2019 via email

@itsmichaeldiego
Copy link
Member

itsmichaeldiego commented May 15, 2019

@barakplasma Let me know if you still interested on this otherwise I will create an issue and ask for help

@barakplasma
Copy link
Contributor

Just to clarify, we are talking about fixing #673, or are we talking about updating the readme? I think we should recommend one "right" way to add libraries.

@itsmichaeldiego
Copy link
Member

@barakplasma I am talking about recommending one "right" way to add libraries, which I think will be under libraries: ['bar', 'foo']. And keeping this way to pass libraries instead of two.

@barakplasma
Copy link
Contributor

barakplasma commented May 16, 2019 via email

@itsmichaeldiego
Copy link
Member

@barakplasma If so I think we should remove the other way, so there is only one way and no collision

@itsmichaeldiego
Copy link
Member

Seems that this was taken care by #921

@itsmichaeldiego
Copy link
Member

@barakplasma @maruf89 Let me know if that works for you folks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants