Skip to content

chore: code clean up #1442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 14, 2021
Merged

chore: code clean up #1442

merged 5 commits into from
Jul 14, 2021

Conversation

slowy07
Copy link
Contributor

@slowy07 slowy07 commented Jul 13, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1441 🦕

@slowy07 slowy07 requested a review from a team as a code owner July 13, 2021 16:50
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 13, 2021
@parthea parthea added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 14, 2021
@parthea parthea changed the title More fixing chore: code clean up Jul 14, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 14, 2021
parthea
parthea previously approved these changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parthea
Copy link
Contributor

parthea commented Jul 14, 2021

Thanks @slowy07!

@parthea parthea added the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jul 14, 2021
@gcf-merge-on-green gcf-merge-on-green bot dismissed parthea’s stale review July 14, 2021 15:28

This review does not reference the most recent commit, and you are using the secure version of merge-on-green. Please re-review the most recent commit.

@slowy07
Copy link
Contributor Author

slowy07 commented Jul 14, 2021 •
edited
Loading

Thanks @slowy07!

thanks !!!! @parthea

@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jul 14, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 14, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit d35c912 into googleapis:master Jul 14, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jul 14, 2021
@slowy07 slowy07 deleted the more-fixing branch July 14, 2021 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthea parthea parthea approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[more] remove unused module
3 participants
@slowy07 @parthea @yoshi-kokoro