Making grpcio install require fewer keystrokes. #1815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
|
||
| gRPC is required for using the Cloud Bigtable API. As of May 2016, | ||
| ``grpcio`` is only supported in Python 2.7, so importing | ||
| :mod:`gcloud.bigtable` will fail. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
- Adding an import error with a nice failure message in `gcloud.bigtable` in the absence of `grpcio` - Making `setup.py` include `grpcio` conditional on being Python 2.7 - Adding a warning to every single Bigtable docs page explaining that it can't be used outside of Python 2.7
| @@ -5,7 +5,7 @@ Base for Everything | |||
|
|
|||
| gRPC is required for using the Cloud Bigtable API. As of May 2016, | |||
| ``grpcio`` is only supported in Python 2.7, so importing | |||
| :mod:`gcloud.bigtable` will fail. | |||
| :mod:`gcloud.bigtable` in other versions of Python in other versions of Python will fail. | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Minor comment re the banner -- otherwise LGTM 👍 |
|
Issue #1858 tracks the DRYness issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gcloud.bigtablein the absence ofgrpciosetup.pyincludegrpcioconditional on being Python 2.7/cc @jgeewax