Skip to content

fix: show slot_millis_sum warning only when allow_large_results=False #1892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2025
Merged

fix: show slot_millis_sum warning only when allow_large_results=False #1892

merged 1 commit into from
Jul 9, 2025

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Jul 9, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 430478956 🦕

@shobsi shobsi requested review from a team as code owners July 9, 2025 09:06
@shobsi shobsi requested a review from GarrettWu July 9, 2025 09:06
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jul 9, 2025
@shobsi shobsi requested a review from Genesis929 July 9, 2025 09:06
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Jul 9, 2025
@shobsi shobsi merged commit 25efabc into main Jul 9, 2025
25 checks passed
@shobsi shobsi deleted the shobsi-allow-large-results-false-warn branch July 9, 2025 22:37
@release-please release-please bot mentioned this pull request Jul 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@shuoweil shuoweil shuoweil approved these changes

@GarrettWu GarrettWu Awaiting requested review from GarrettWu GarrettWu is a code owner automatically assigned from googleapis/api-bigquery-dataframe

@Genesis929 Genesis929 Awaiting requested review from Genesis929

Assignees

@tswast tswast

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shobsi @tswast @shuoweil