perf: Improve axis=1 aggregation performance #2036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chelsea-lin
requested changes
Aug 28, 2025
| @@ -353,6 +354,36 @@ def _(self, op: ops.ScalarOp, input: pl.Expr) -> pl.Expr: | |||
| assert isinstance(op, json_ops.JSONDecode) | |||
| return input.str.json_decode(_DTYPE_MAPPING[op.to_type]) | |||
|
|
|||
| @compile_op.register(arr_ops.ToArrayOp) | |||
There was a problem hiding this comment.
do we have any engine or system tests for these two new ops?
There was a problem hiding this comment.
Mostly, relying on existing aggregate axis=1 tests, though have now added some engine tests for the new ops
| @@ -699,6 +699,9 @@ def visit_ArrayFilter(self, op, *, arg, body, param): | |||
| def visit_ArrayMap(self, op, *, arg, body, param): | |||
| return self.f.array(sg.select(body).from_(self._unnest(arg, as_=param))) | |||
|
|
|||
| def visit_ArrayReduce(self, op, *, arg, body, param): | |||
| return sg.select(body).from_(self._unnest(arg, as_=param)).subquery() | |||
There was a problem hiding this comment.
maybe use self.f.array(...) rather than subquery() similar as other visit_Array* methods in this file?
There was a problem hiding this comment.
Those other methods output an array, arrayreduce produces a single scalar for each input array, so I don't think we want self.f.array() here
chelsea-lin
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕