refactor: consolidate BigQuery client creation and set user-agent #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tswast
commented
Mar 31, 2021
| project_id = default_project | ||
|
|
||
| return bigquery.Client( | ||
| client_info=google_client_info(), |
There was a problem hiding this comment.
Need to add hook to check if client_info is available before trying to add it.
There was a problem hiding this comment.
Actually, 1.12.0 was released 2019-05-16. That's close enough to the NEP 29 recommended 2 years, that I think it's worth just bumping the minimum version of google-cloud-bigquery in this case.
shollyman
approved these changes
Mar 31, 2021
|
@shollyman re: default project lookup, most of the hard work is done by We don't hit that line if someone specifies a service account key, in which case we use the project ID from the JSON key file. That's consistent with what the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating as draft, as I want to add unit tests first.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #98 🦕