test: only create test tables if they do not already exist #101
Conversation
This should avoid race conditions when creating views from recently (re)created tables.
There was a problem hiding this comment.
LGTM, though another refinement might be to put all the table generation in a SQL file or text blob, and run it as a set of CREATE TABLE ... IF NOT EXISTS ... AS SELECT statements. Then you can just gate on successful query or not.
Suppose it comes down to whether this kind of probe-or-build logic is more preferred to maintaining the SQL files, and it may be a wash if we end up centralizing sample tables.
That's a good idea. Hopefully this method doesn't give us trouble, but if it does I can switch to that. P.S. I actually did switch to DDL in the Ibis tests https://github.com/ibis-project/ibis/blob/master/ci/schema/bigquery.sql, though there we have the data in separate files at https://github.com/ibis-project/testing-data and don't actually create the tables as part of test setup. We expect a human to run a script to load the data once on the test project. |
This should avoid race conditions when creating views from recently
(re)created tables.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #99 🦕