Skip to content

test: move table creation to temporary dataset #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 13, 2021
Merged

test: move table creation to temporary dataset #124

merged 2 commits into from
Apr 13, 2021

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Apr 13, 2021 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #123 🦕

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 13, 2021
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. label Apr 13, 2021
@tswast tswast requested review from shollyman and jimfulton April 13, 2021 14:48
@tswast tswast added the automerge Merge the pull request once unit tests and other checks pass. label Apr 13, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 9179193 into googleapis:master Apr 13, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimfulton jimfulton jimfulton approved these changes

@shollyman shollyman Awaiting requested review from shollyman

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flake: test_table_create can cause table list test to fail
2 participants
@tswast @jimfulton