-
Notifications
You must be signed in to change notification settings - Fork 139
Fix supports_multivalues_insert feature name #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR fixes multivalues insertion feature that was broken due to a typo
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Thanks. It's a shame there wasn't a test to catch this in the first place. Can you think of a test for this? Maybe looking at the way inserts get generated? If not, I will. :) |
Hey @jimfulton, I would appreciate your help in adding tests. |
OK. Created #226 to track. |
@devbis this doesn't do what I guessed it did. :) What motivated you to do this -- what breaks without it? |
Reopening to see if any tests are affected. |
Sorry for the delay.
I want to make the following insert in SQL
It takes the same time as a single insertion, but I can uploads many items at once. And without this feature enabled SQLalchemy doesn't allow to do it. |
Thanks. Hm, that's what I thought too... I'll look some more. |
This PR fixes multivalues insertion feature that was broken due to a typo
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕