Skip to content

feat: add support for SQLAlchemy 1.4 #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

alonme
Copy link
Contributor

@alonme alonme commented Mar 19, 2021

Still a draft, need to make sure all this changes will not break users in older versions of SQLA

@alonme
Copy link
Contributor Author

alonme commented Mar 19, 2021

closes #83

@tswast
Copy link
Collaborator

tswast commented Mar 19, 2021

Thanks! Let me know once this is ready for review.

@alonme
Copy link
Contributor Author

alonme commented Mar 21, 2021

@tswast - Almost ready,
I'm debating about having SQLA 1.4 a dev requirement (for tests)
and about 1 issue of backward compatibility, which might be an issue only if someone actually passed inline to BigQueryCompiler

@tswast
Copy link
Collaborator

tswast commented Mar 22, 2021

I'm debating about having SQLA 1.4 a dev requirement (for tests)

Ideally we'd have some test sessions for our minimum requirements as well as the latest supported. I've created #85 to track this.

@tswast
Copy link
Collaborator

tswast commented Mar 22, 2021

In the meantime, I'm okay adding a dev requirement.

@tswast
Copy link
Collaborator

tswast commented Mar 23, 2021

@alonme Apologies, but I just "blackened" all the source in this repo. It will most likely cause some conflicts.

In good news, we do now have "constraints" files in the testing/ directory which allow us to test against specific package versions for each of our test sessions. Plain ol' pytest should still work, but to use that multi-version testing, we can run with nox http://nox.thea.codes/

@tswast tswast added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 25, 2021
@tswast tswast changed the title Support sqla 1.4 feat: add support for SQLAlchemy 1.4 Mar 29, 2021
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. label Apr 7, 2021
@jimfulton
Copy link
Contributor

See: #177

@jimfulton jimfulton closed this May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants