This repository was archived by the owner on Oct 31, 2023. It is now read-only.
Add DevPlat as CodeOwners #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…binary-authorization into add-devplat-codeowner
busunkim96
reviewed
Mar 24, 2021
| "api_id": "binaryauthorization.googleapis.com", | ||
| "codeowner_team": "@googleapis/cicd" |
There was a problem hiding this comment.
Please add this team to the .github/CODEOWNERS file manually (Python doesn't currently autogen CODEOWNERS files)
If you could also file a feature request on synthtool for Python to respect codeowner_team in repo-metadata.json that would be great.
There was a problem hiding this comment.
Updated the CODEOWNERS file and also filed a feature in the synthool here. Please do confirm that the feature request is what was expected and is correct.
busunkim96
approved these changes
Mar 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.