Skip to content

Add CI Tests for GOOGLE_CLOUD_DISABLE_GRPC request flow #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
crwilcox opened this issue Dec 9, 2020 · 0 comments · Fixed by #136
Closed

Add CI Tests for GOOGLE_CLOUD_DISABLE_GRPC request flow #133

crwilcox opened this issue Dec 9, 2020 · 0 comments · Fixed by #136
Assignees
@crwilcox
Labels
api: datastore Issues related to the googleapis/python-datastore API. help wanted We'd love to have community involvement on this issue. type: process A process-related concern. May include testing, release, or the like.

Comments

@crwilcox
Copy link
Contributor

crwilcox commented Dec 9, 2020

Set up tests/CI to exercise the library with GOOGLE_CLOUD_DISABLE_GRPC set. Otherwise that request flow is not validated at all.
@crwilcox crwilcox added help wanted We'd love to have community involvement on this issue. type: process A process-related concern. May include testing, release, or the like. labels Dec 9, 2020
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/python-datastore API. label Dec 9, 2020
@crwilcox crwilcox mentioned this issue Dec 9, 2020
Closed
tseaver added a commit that referenced this issue Dec 9, 2020
@tseaver
tests: run systests also w/ GRPC disabled.
2f920ec 
Closes #133.
@tseaver tseaver mentioned this issue Dec 9, 2020
Merged
crwilcox pushed a commit that referenced this issue Dec 9, 2020
@tseaver
fix: make HTTPDatastoreAPI compatible w/ microgen Gapic API (#136)
d522799 
* tests: refactor to helpers for repeated tests

* fix: update 'HTTPDatastoreAPI.allocate_ids' to follow request-only pattern

Toward #124

* fix: add missing 'HTTPDatastoreAPI.reserve_ids' method

Closes #134.

* fix: update 'HTTPDatastoreAPI.rollback' to follow request-only pattern

Toward #124

* fix: update 'HTTPDatastoreAPI.commit' to follow request-only pattern

Toward #124

* fix: update 'HTTPDatastoreAPI.begin_transaction' to follow request-only pattern

Toward #124

* fix: update 'HTTPDatastoreAPI.run_query' to follow request-only pattern

Toward #124

* fix: update 'HTTPDatastoreAPI.lookup' to follow request-only pattern

Toward #124

* fix: add 'retry' / 'timeout' args to HTTPDatastoreAPI methods

Closes #124.

* chore: lint

* tests: run systests also w/ GRPC disabled.

Closes #133.
tseaver added a commit that referenced this issue Dec 14, 2020
@tseaver
chore: preserve gRPC-disabled systests during synth
8bf0ccb 
See #133, #136
@tseaver tseaver mentioned this issue Dec 14, 2020
Merged
crwilcox pushed a commit that referenced this issue Apr 21, 2021
@tseaver
chore: preserve gRPC-disabled systests during synth (#141)
3c8da54 
See #133, #136
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crwilcox crwilcox

Labels
api: datastore Issues related to the googleapis/python-datastore API. help wanted We'd love to have community involvement on this issue. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: make HTTPDatastoreAPI compatible w/ microgen Gapic API googleapis/python-datastore
1 participant
@crwilcox