Skip to content

Add coverage for query offset fix #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tseaver opened this issue Apr 21, 2021 · 2 comments · Fixed by #165
Closed

Add coverage for query offset fix #158

tseaver opened this issue Apr 21, 2021 · 2 comments · Fixed by #165
Assignees
@tseaver
Labels
api: datastore Issues related to the googleapis/python-datastore API. type: process A process-related concern. May include testing, release, or the like.

Comments

@tseaver
Copy link
Contributor

tseaver commented Apr 21, 2021

/cc @crwilcox

PR #18 did not add coverage for the case it was fixing.

nox > Running session cover
nox > Re-using existing virtual environment at .nox/cover.
nox > python -m pip install coverage pytest-cov
nox > coverage report --show-missing --fail-under=97
Name                                                                                  Stmts   Miss Branch BrPart  Cover   Missing
---------------------------------------------------------------------------------------------------------------------------------
google/cloud/datastore/__init__.py                                                        9      0      0      0   100%
google/cloud/datastore/_app_engine_key_pb2.py                                            23      0      2      0   100%
google/cloud/datastore/_gapic.py                                                         15      0      2      0   100%
google/cloud/datastore/_http.py                                                          72      0     12      0   100%
google/cloud/datastore/batch.py                                                         106      0     32      0   100%
google/cloud/datastore/client.py                                                        230      0    118      0   100%
google/cloud/datastore/entity.py                                                         23      0      6      0   100%
google/cloud/datastore/helpers.py                                                       206      0    132      0   100%
google/cloud/datastore/key.py                                                           202      0     76      0   100%
google/cloud/datastore/query.py                                                         202      3     64      1    98%   588->596, 596-598
...
@tseaver tseaver added the type: process A process-related concern. May include testing, release, or the like. label Apr 21, 2021
@tseaver tseaver self-assigned this Apr 21, 2021
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/python-datastore API. label Apr 21, 2021
@craiglabenz
Copy link
Contributor

I had been wondering about this. To state the obvious, CI is not currently blocking on test coverage below 100%. Is this intentional?

@tseaver
Copy link
Contributor Author

tseaver commented Apr 27, 2021

@craiglabenz We've been below 100% since the microgenerator merge back in October 2020. I consider it a fairly big process flaw, and fixing this bit is the last "manual" gap (the others are all in autogenerated async client code, see googleapis/gapic-generator-python#632).

tseaver added a commit that referenced this issue May 3, 2021
@tseaver
tests: add coverage for skip < offset case
e44a27a 
Closes #158
@tseaver tseaver mentioned this issue May 3, 2021
Merged
tseaver added a commit that referenced this issue May 18, 2021
@tseaver
tests: add coverage for skip < offset case (#165)
0da3e22 
Closes #158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
api: datastore Issues related to the googleapis/python-datastore API. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests: add coverage for skip < offset case googleapis/python-datastore
2 participants
@tseaver @craiglabenz