-
Notifications
You must be signed in to change notification settings - Fork 44
chore: use gcp-sphinx-docfx-yaml for docfx #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The readme for the gcp-sphinx-docfx-yaml
repository says "for personal or experimental use", but I guess since we control it, we can live with that.
BTW, why was that repo created de-novo, instead of Github-forking the docascode version?
Hrm it might not be listed as a fork because of the internal repo creation process. Perhaps The main issue we had with |
For it to be under |
@googleapis/firestore-dpe Friendly ping |
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
closing this as #161 was already merged |
No description provided.