Skip to content

chore: use gcp-sphinx-docfx-yaml for docfx #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

busunkim96
Copy link
Contributor

No description provided.

@busunkim96 busunkim96 requested a review from a team April 6, 2021 00:15
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/python-datastore API. label Apr 6, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 6, 2021
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The readme for the gcp-sphinx-docfx-yaml repository says "for personal or experimental use", but I guess since we control it, we can live with that.

BTW, why was that repo created de-novo, instead of Github-forking the docascode version?

@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 14, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 14, 2021
@busunkim96
Copy link
Contributor Author

BTW, why was that repo created de-novo, instead of Github-forking the docascode version?

Hrm it might not be listed as a fork because of the internal repo creation process. Perhaps googleapis doesn't let you create new repos through the GItHub UI? I think it was intended to be a fork though. @dandhlee?

The main issue we had with sphinx-docfx-yaml was that it pins to an old specific version of sphinx

@dandhlee
Copy link
Contributor

For it to be under googleapis it needed to go through the internal release process, which does make it look like a standalone product/repository rather than a fork.

@busunkim96
Copy link
Contributor Author

@googleapis/firestore-dpe Friendly ping

@busunkim96 busunkim96 added the automerge Merge the pull request once unit tests and other checks pass. label Apr 29, 2021
@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 29, 2021
@dandhlee dandhlee added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Apr 29, 2021
@dandhlee
Copy link
Contributor

closing this as #161 was already merged

@dandhlee dandhlee closed this Apr 29, 2021
@dandhlee dandhlee deleted the busunkim96-patch-1 branch April 29, 2021 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the googleapis/python-datastore API. cla: yes This human has signed the Contributor License Agreement. kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants