Triage remaining gorepo test failures in 1.18 #1131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixedbugs/issue46938.go tests checkptr mode, which is unapplicable
to GopherJS.
- fixedbugs/issue47928.go tests //go:nointerface pragma, which is not
a part of the Go spec.
- fixedbugs/issue49665.go will be re-enabled in Go 1.19, where -G=3
flag is removed; it would have passed if not for the unsupported
flag.
By a happy accident gopherjs@2bf901a fixed the issue.
This addresses golang/go#49110 for GopherJS.
This isn't a new regression in Go 1.18 and there seem to be several distinct bugs affecting it, so it's reasonable to address it as a separate issue: gopherjs#1128.
Although we could support this function, we currently do not and the `unsafe` package generally has limited support status. Filed gopherjs#1130 to track this.
flimzy
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short summary of changes:
unsafepackage. We could support it in future, but it's not a trivial fix, and it isn't a new regression. I filed a separate issue for this.At this point all CI should be green and the only major TODOs are supporting test-like execution of fuzz tests and generics.
Updates #1092.