Fixing internalization of null slice and array fields #1303
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #1300
Now that externalization work better for
nil
orzero
tonull
(done in #1194 as part of #617), we need to be able to internalizenull
values intonil
orzero
. Currently we get an exception because internalization isn't expecting anull
value for a slice or array.Internalization of an externalized array creates a copy making the value unassignable (see #1302). Until that is fixed, trying to internalize a null array will simply throw an exception. This is favorable over returning a zero value which will quietly hide the array problem and still not be assignable.