[WIP] Automatically add minify build tag when -m is specified #612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitshur
reviewed
Mar 21, 2017
There was a problem hiding this comment.
I think the implementation should be moved to github.com/gopherjs/gopherjs/build package.
build.NewSession is given the value of options. It can copy the value of Minify from there. Then it's available inside Session.BuildPackage and others.
It's not neccessary to address this before we come to a decision on the proposal, just leaving the comment for future reference.
|
Closing per #611 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A WIP PR based on discussion in #611
Should probably be accompanied by some documentation in the wiki that defines this now well-known build tag
minify