Skip to content

[WIP] Automatically add minify build tag when -m is specified #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[WIP] Automatically add minify build tag when -m is specified #612

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions tool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@ import (
"golang.org/x/crypto/ssh/terminal"
)

const (
minifyBuildTag = "minify"
)

var currentDirectory string

func init() {
Expand Down Expand Up @@ -92,6 +96,9 @@ func main() {
cmdBuild.Flags().AddFlag(flagLocalMap)
cmdBuild.Run = func(cmd *cobra.Command, args []string) {
options.BuildTags = strings.Fields(*tags)
if options.Minify {
options.BuildTags = append(options.BuildTags, minifyBuildTag)
}
for {
s := gbuild.NewSession(options)

Expand Down Expand Up @@ -174,6 +181,9 @@ func main() {
cmdInstall.Flags().AddFlag(flagLocalMap)
cmdInstall.Run = func(cmd *cobra.Command, args []string) {
options.BuildTags = strings.Fields(*tags)
if options.Minify {
options.BuildTags = append(options.BuildTags, minifyBuildTag)
}
for {
s := gbuild.NewSession(options)

Expand Down Expand Up @@ -322,6 +332,9 @@ func main() {
cmdTest.Flags().AddFlag(flagLocalMap)
cmdTest.Run = func(cmd *cobra.Command, args []string) {
options.BuildTags = strings.Fields(*tags)
if options.Minify {
options.BuildTags = append(options.BuildTags, minifyBuildTag)
}
err := func() error {
pkgs := make([]*gbuild.PackageData, len(args))
for i, pkgPath := range args {
Expand Down Expand Up @@ -517,6 +530,9 @@ func main() {
cmdServe.Flags().StringVarP(&addr, "http", "", ":8080", "HTTP bind address to serve")
cmdServe.Run = func(cmd *cobra.Command, args []string) {
options.BuildTags = strings.Fields(*tags)
if options.Minify {
options.BuildTags = append(options.BuildTags, minifyBuildTag)
}
dirs := append(filepath.SplitList(build.Default.GOPATH), build.Default.GOROOT)
var root string

Expand Down