vendor: vendor go/types to workaround bug in method set calc. #811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per golang/go#25008 (comment) the fix for method set calculation will not be back ported to Go 1.10. Instead gri suggests we vendor the latest version of go/types. This PR does just that. It is effectively a temporary sticking plaster until Go 1.11 lands, or more specifically until we release GopherJS for Go 1.11. In order to successfully vendor go/types, however, we need to move compiler/vendor to the repo root (because build also uses go/types). And because golang.org/x/tools/go/gcexportdata and golang.org/x/tools/go/types/typeutil also reference go/types we need to vendor them as well. vendor/vendor.json is updated using govendor, with the one exception being a manual addition for go/types (govendor doesn't appear to understand how to vendor a standard library package). Fixes gopherjs#808.
|
Closing this pull request, since we are long past Go 1.11 and the upstream fix is available to us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per golang/go#25008 (comment) the
fix for method set calculation will not be back ported to Go 1.10.
Instead gri suggests we vendor the latest version of go/types. This PR
does just that. It is effectively a temporary sticking plaster until Go
1.11 lands, or more specifically until we release GopherJS for Go 1.11.
In order to successfully vendor go/types, however, we need to move
compiler/vendor to the repo root (because build also uses go/types). And
because golang.org/x/tools/go/gcexportdata and
golang.org/x/tools/go/types/typeutil also reference go/types we need to
vendor them as well.
vendor/vendor.json is updated using govendor, with the one exception
being a manual addition for go/types (govendor doesn't appear to
understand how to vendor a standard library package).
Fixes #808.