Skip to content

add internal/reflectlite for support Go1.13 #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

add internal/reflectlite for support Go1.13 #959

wants to merge 7 commits into from

Conversation

visualfc
Copy link
Contributor

@visualfc visualfc commented Jan 26, 2020 •
edited
Loading 

cd github.com/gopherjs/gopherjs
git checkout go1.13
go install --tags gopherjsdev
  • add internal/reflectlite for support Go1.13 for fixed Go 1.13 support #929
  • update syscall/js API for Go 1.13 api changes
  • build go project use go.mod
    go mod tidy
    gopherjs build -v

=======================
Test GopherJS on Go 1.13 / Go 1.14

cd goproj/src
git clone https://github.com/visualfc/gopherjs github.com/gopherjs/gopherjs
cd github.com/gopherjs/gopherjs
git checkout go1.13 //build on Go 1.13
git checkout go1.14 //build on Go 1.14
go install --tags gopherjsdev

@visualfc visualfc requested a review from hajimehoshi January 26, 2020 00:14
@hajimehoshi hajimehoshi requested a review from dmitshur January 26, 2020 05:19
@dmitshur
Copy link
Member

dmitshur commented Feb 2, 2020

CI is failing with:

CircleCI was unable to run the job runner because we were unable to execute commands in build container.

This typically means that the build container entrypoint or command is terminating the container prematurely, or interfering with executed commands. Consider clearing entrypoint/command values and try again.

Any ideas why that is? Is it just broken on master too?

@FrankReh FrankReh mentioned this pull request Feb 3, 2020
Open
@visualfc visualfc force-pushed the go1.13 branch 2 times, most recently from 48b7f00 to 3e8fc9f Compare February 8, 2020 00:53
@visualfc visualfc closed this Feb 8, 2020
@visualfc visualfc deleted the go1.13 branch February 15, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hajimehoshi hajimehoshi Awaiting requested review from hajimehoshi

@dmitshur dmitshur Awaiting requested review from dmitshur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@visualfc @dmitshur