-
-
Notifications
You must be signed in to change notification settings - Fork 80
Add featured projects and ecosystem section #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -0,0 +1,17 @@ | |||
--- | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that normal for a JS file? O.o
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, that activates the template engine. See the {{ site.data.projects | where: "featured",true | size }}
line.
let elem = $('.featured-apps'); | ||
if (elem) { | ||
elem.slick({ | ||
autoplay: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure all this can be done with CSS3 animations, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the animations, yes. Slick uses CSS3 for animations internally. But I don't think there is a chance for changing slides and especially swipe support without js.
Overall, that seems like a lot of adds for just a slider... Can't we just have something simpler? :-/ |
If you remove swipe support it's probably not too hard to code it in js manually. But I wouldn't do it if we have a better solution with less work. |
Do you mind if I give it a try? I finish something else first then I'll check what I can do. |
Not at all!! :) |
@GuillaumeGomez what's you time schedule on this? Thinking about splitting the unrelated changes into another PR. |
Ah yes, please do so I don't block all the changes. |
@@ -15,6 +15,10 @@ | |||
|
|||
{% include layout_footer.html %} | |||
|
|||
<script type="text/javascript" src="/js/jquery-1.11.0.min.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't notice before but they're now included in most pages whereas they're not used. (Going through the stuff hehe)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a dependency of the slider
Based on the "slick" carousel. This is also used by gtk.org.
5e24d60
to
ec4b155
Compare
Superseded by #234 |
by gtk.org.
Todo
Closes #213, #208