Skip to content

Add featured projects and ecosystem section #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

sophie-h
Copy link
Contributor

@sophie-h sophie-h commented Jun 17, 2021

  • Featured Projects: Based on the "slick" carousel. This is also used
    by gtk.org.
  • Ecosystem: Link to gstreamer-rs, libhandy-rs, libadwaita-rs.
Todo
  • Agree on featured apps
  • Better screenshots

Closes #213, #208

@sophie-h sophie-h marked this pull request as draft June 17, 2021 21:03
@sophie-h
Copy link
Contributor Author

image

@@ -0,0 +1,17 @@
---
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that normal for a JS file? O.o

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that activates the template engine. See the {{ site.data.projects | where: "featured",true | size }} line.

let elem = $('.featured-apps');
if (elem) {
elem.slick({
autoplay: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure all this can be done with CSS3 animations, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the animations, yes. Slick uses CSS3 for animations internally. But I don't think there is a chance for changing slides and especially swipe support without js.

@GuillaumeGomez
Copy link
Member

Overall, that seems like a lot of adds for just a slider... Can't we just have something simpler? :-/

@sophie-h
Copy link
Contributor Author

If you remove swipe support it's probably not too hard to code it in js manually. But I wouldn't do it if we have a better solution with less work.

@GuillaumeGomez
Copy link
Member

Do you mind if I give it a try? I finish something else first then I'll check what I can do.

@sophie-h
Copy link
Contributor Author

Do you mind if I give it a try?

Not at all!! :)

@sophie-h
Copy link
Contributor Author

@GuillaumeGomez what's you time schedule on this? Thinking about splitting the unrelated changes into another PR.

@GuillaumeGomez
Copy link
Member

Ah yes, please do so I don't block all the changes.

@@ -15,6 +15,10 @@

{% include layout_footer.html %}

<script type="text/javascript" src="/js/jquery-1.11.0.min.js"></script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't notice before but they're now included in most pages whereas they're not used. (Going through the stuff hehe)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a dependency of the slider

sophie-h added 2 commits June 19, 2021 16:09
Based on the "slick" carousel. This is also used by gtk.org.
@sophie-h sophie-h force-pushed the sophie-h/featured-projects branch from 5e24d60 to ec4b155 Compare June 19, 2021 14:16
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jun 19, 2021
@sophie-h
Copy link
Contributor Author

Superseded by #234

@sophie-h sophie-h closed this Jun 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Projects using gtk-rs: Add carousel/slideshow
2 participants