Skip to content

Add basic Vue.js component and examples. #2544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Aug 6, 2020

Conversation

joshgoebel
Copy link
Member

Resolves #2535.

@joshgoebel
Copy link
Member Author

Still need to go back and clean up the developer stuff to properly integrate it. Figured developer tool is an easy please to eat our own dogwood on this one.

@egor-rogov
Copy link
Collaborator

Do I understand correctly that this is still WIP?

@joshgoebel
Copy link
Member Author

Only the developer tool tweaks. I think the plugin itself is good.

@joshgoebel joshgoebel added this to the 10.1 milestone May 19, 2020
@joshgoebel
Copy link
Member Author

@egor-rogov Done.

@joshgoebel joshgoebel requested review from egor-rogov and allejo June 8, 2020 14:52
@joshgoebel
Copy link
Member Author

Copy link
Collaborator

@egor-rogov egor-rogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good for me, but maybe you want someone knowledgeable in Vue to look into this.

But what are the advantages of using Vue in developer.html, I wonder? Why do we need vue.js and vue.runtime.js in the repository?

@joshgoebel
Copy link
Member Author

But what are the advantages of using Vue in developer.html, I wonder?

To eat our own dog food. If we support Vue, we might as well use it in developer - even if only as a quick way to get bugs reported if the integration breaks for some reason.

Why do we need vue.js and vue.runtime.js in the repository?

I vendored them for the same reason we vendor jquery - to have a pinned version. Or are you asking why we need both? Technically we could just include the one...

@egor-rogov
Copy link
Collaborator

egor-rogov commented Jun 11, 2020

To eat our own dog food

It makes sense, but what if we decide to provide another plugin for some other framework?

@joshgoebel
Copy link
Member Author

joshgoebel commented Jun 11, 2020

It makes sense, but what if we decide to provide another plugin for some other framework?

shrugs Can't solve all the worlds problems in one day. :-) Even if this only helps Vue it's still a benefit IMHO.

@egor-rogov
Copy link
Collaborator

What helps Vue is the plugin, not our developer tool. Keeping it simple also makes sense for me, as well as "to eat our own dog food".

@joshgoebel
Copy link
Member Author

I meant it helps Vue indirectly as in gives us another reason to keep the plugin maintained. :-)

@joshgoebel joshgoebel modified the milestones: 10.1, 10.2 Jun 11, 2020
@joshgoebel
Copy link
Member Author

@allejo All good?

@joshgoebel joshgoebel merged commit 8965ebe into highlightjs:master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Propose: Better support Vue simple use cases
3 participants