-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Add basic Vue.js component and examples. #2544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Still need to go back and clean up the developer stuff to properly integrate it. Figured developer tool is an easy please to eat our own dogwood on this one. |
Do I understand correctly that this is still WIP? |
Only the developer tool tweaks. I think the plugin itself is good. |
@egor-rogov Done. |
Tests are green: https://travis-ci.org/github/highlightjs/highlight.js/pull_requests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good for me, but maybe you want someone knowledgeable in Vue to look into this.
But what are the advantages of using Vue in developer.html, I wonder? Why do we need vue.js and vue.runtime.js in the repository?
To eat our own dog food. If we support Vue, we might as well use it in developer - even if only as a quick way to get bugs reported if the integration breaks for some reason.
I vendored them for the same reason we vendor |
It makes sense, but what if we decide to provide another plugin for some other framework? |
shrugs Can't solve all the worlds problems in one day. :-) Even if this only helps Vue it's still a benefit IMHO. |
What helps Vue is the plugin, not our developer tool. Keeping it simple also makes sense for me, as well as "to eat our own dog food". |
I meant it helps Vue indirectly as in gives us another reason to keep the plugin maintained. :-) |
@allejo All good? |
Resolves #2535.