Skip to content

Reflect changes in Tuya's IoT Platform names and structure #19569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 23 commits into from
Closed

Reflect changes in Tuya's IoT Platform names and structure #19569

wants to merge 23 commits into from

Conversation

drthanwho
Copy link
Contributor

Proposed change

  1. Tuya IoT Platform has changed some names and structure of their pages that contradict with current instructions
    Updated names based on current edition of their platform.
  2. Addition of ΝΟΤΕ about being prompted to subscribe to a plan to clarify this is free.
  3. Fix of a rogue NOTE 😅
  4. New screenshots to reflect the changes

📌 Needs to be added to 2021.10 milestone

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in current documentation (current branch).
  • Updated documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue:

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Oct 2, 2021
@probot-home-assistant probot-home-assistant bot added next This PR goes into the next branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Oct 2, 2021
@ludeeus ludeeus added this to the 2021.10.0 milestone Oct 3, 2021
@home-assistant home-assistant deleted a comment from probot-home-assistant bot Oct 3, 2021
@ludeeus ludeeus removed in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Oct 3, 2021
ludeeus
ludeeus previously requested changes Oct 3, 2021
View reviewed changes
frenck
frenck requested changes Oct 4, 2021
View reviewed changes
source/_integrations/tuya.markdown Outdated

#### Prerequisites

You have created an account for [Tuya Smart or Smart Life app](https://developer.tuya.com/en/docs/iot/tuya-smart-app-smart-life-app-advantages?id=K989rqa49rluq#title-1-Download).

You have created an account for the [Tuya IoT Platform](https://iot.tuya.com/).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is what the above line already says?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line above is for the app, this line is for the IoT platform, you need both (no the same account)

@frenck
Copy link
Member

frenck commented Oct 4, 2021

Honestly, I think the order of the page is wrong. Prerequisites should be shown above the Home Assistant configuration instructions. Currently, it is the wrong way around, causing it to be a bit weird in terms of order/flow to set things up.

@drthanwho
Copy link
Contributor Author

Honestly, I think the order of the page is wrong. Prerequisites should be shown above the Home Assistant configuration instructions. Currently, it is the wrong way around, causing it to be a bit weird in terms of order/flow to set things up.

Yeah that is actually a very good point about the prerequisites. You won't be able to do anything without those steps. Let me see what I can do. But not just the prerequisites right? All the instructions for IoT platform first then the MyHA button.

@frenck
Copy link
Member

frenck commented Oct 4, 2021

All the instructions for IoT platform first then the MyHA button.

Yes :)

@drthanwho
Copy link
Contributor Author

drthanwho commented Oct 4, 2021 •
edited
Loading

Ok maybe this is better now? Removed all NOTE windows in the end. I am still not a big fan of the huge troubleshooting table. But didn't touch it for now.

Oh and three new screenshot but will add after this. If order is changed should all screenshots be readded on correct order? Since now last screenshot is 003.

@frenck
Copy link
Member

frenck commented Oct 4, 2021

@drthanwho There is a merge conflict (due to change made in the config flow). Could you rebase this PR to resolve that conflict?

@drthanwho
Copy link
Contributor Author

Yeah I'm gonna start all over again with a new PR. I have no idea what I'm doing with trying to rebase and clearly it's not working

@drthanwho drthanwho mentioned this pull request Oct 4, 2021
Merged
8 tasks
@drthanwho
Copy link
Contributor Author

Let's forget this one ever happened 😅

@drthanwho drthanwho closed this Oct 4, 2021
@probot-home-assistant probot-home-assistant bot removed the Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! label Oct 4, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ludeeus ludeeus ludeeus left review comments

@frenck frenck frenck requested changes

Assignees
No one assigned
Labels
cla-signed next This PR goes into the next branch
Projects
None yet
Milestone
2021.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@drthanwho @frenck @ludeeus @homeassistant