Skip to content

Add new documentation concerning icons #22140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 16, 2023

Conversation

mririgoyen
Copy link
Contributor

@mririgoyen mririgoyen commented Mar 23, 2022

Proposed change

Icons are a large part of Home Assistant, however we have little information in our official documentation about them. In this PR I have added a dedicated page to frontend icons that provides our users with information on how to find icons, suggest new icons and aliases, and even contribute icons to the MDI project!

Additionally, I have updated the Frontend landing page.


This is only a first stage. I would like to expand on the icon documentation by adding another page with a curated list of icons by entity category in the future. However, that will require getting MDI into the docs site (replacing Font Awesome), which I have started to do in another branch.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant bot added the current This PR goes into the current branch label Mar 23, 2022
@frenck frenck self-requested a review March 27, 2022 11:11
@github-actions

This comment was marked as resolved.

@github-actions github-actions bot added the Stale The PR had no activity for quite some time, and is marked as Stale label May 26, 2022
@github-actions github-actions bot closed this Jun 2, 2022
@frenck frenck reopened this Jun 2, 2022
@frenck
Copy link
Member

frenck commented Jun 2, 2022

Do not close to this one little bot... this is waiting for us to review it

@frenck frenck removed the Stale The PR had no activity for quite some time, and is marked as Stale label Jun 2, 2022
@github-actions

This comment was marked as duplicate.

@github-actions github-actions bot added the Stale The PR had no activity for quite some time, and is marked as Stale label Aug 1, 2022
@mririgoyen
Copy link
Contributor Author

@frenck Stale again. Anything I can do to help move this along?

@github-actions github-actions bot removed the Stale The PR had no activity for quite some time, and is marked as Stale label Aug 1, 2022
@github-actions

This comment was marked as duplicate.

@github-actions github-actions bot added the Stale The PR had no activity for quite some time, and is marked as Stale label Sep 30, 2022
@frenck

This comment was marked as resolved.

@github-actions github-actions bot removed the Stale The PR had no activity for quite some time, and is marked as Stale label Oct 1, 2022
@github-actions

This comment was marked as resolved.

@github-actions github-actions bot added the Stale The PR had no activity for quite some time, and is marked as Stale label Nov 30, 2022
@frenck

This comment was marked as resolved.

@github-actions github-actions bot removed the Stale The PR had no activity for quite some time, and is marked as Stale label Nov 30, 2022
@mririgoyen
Copy link
Contributor Author

@frenck We just actually deprecated the MDI website and some of the URLs and info here are outdated. Let me update this in a couple hours before you fully merge.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mririgoyen 👍

@frenck frenck merged commit 46ff9f5 into home-assistant:current Jan 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed current This PR goes into the current branch
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants